It's no secret that many of the appointments in the new Administration have ranged from risible to disastrous. But in appointing LTG H.R. McMaster to the post of National Security Advisor the new President lay just, possibly, have gotten one right.
McMaster is a genuine rarity among U.S. Army general officers; a leader who actually thinks about and studies his craft. His reputation among his peers was as something of an iconoclast dating back to the 1990s when he wrote a dissertation (and then publishing in book form) that broke with the Army's conceit that the Vietnam War was "lost" through civilian mismanagement and popular demoralization to point out that the then-leaders of the Army knew that their means and methods were not solving the problem that was the RVN's shambolic government. In the Oughts McMaster was part of a group of senior field-grade officers that made a similar point about the occupation of Iraq.
Obviously - since this is always the question about Trump - the real problem is that we don't know yet what the constraints on McMaster will be and how effective he can and will be in pounding geopolitical sense into the granny's attic that is the Tangerine Toddler's head. The candidate before him 86ed the offer because of too many strings Trump attached to the post, including, supposedly, retaining political oxygen-thieves like K.T. McFarland.
Trump's boast is that he's assembling the "best people" for his administration.
Betsy DeVos is a walking refutation to that nonsense.
Still. In tapping LTG McMaster for NSA even a skeptic like me has to admit; he has, indeed, got one of the best people for this job.